Minimal test - unnecessarily hard to compile
I've just tried to start using the minimal test facility. Unfortunately it fails to compile, and there's no way I can fix that without radically changing my build configuration. My code has #include "boost/test/minimal.hpp" in it; my include path includes a directory which has a boost directory within it containing all the boost headers, so this works fine. But minimal.hpp includes the line #include <libs/test/src/execution_monitor.cpp> which fails to compile - because my include path doesn't have a directory with the boost libs directory in it. And nor should it. This is unfortunate, and arguably a violation of the header policy (libs as a sub-directory name is highly likely to clash with other libraries, unlike boost). Header files should not be including implementation files. This is especially the case with the minimal test facility, whose whole point is to be usable without requiring linking with implementation files. Changing to textual inclusion of implementation files is not a great improvement. Could the necessary implementation detail not be moved into some header files, which can then be included as necessary by both the cpp files and minimal.hpp? (Note that this is not a new issue - see also http://lists.boost.org/MailArchives/boost/msg05435.php) - Alan
On Oct 5, 2004, at 6:42 AM, Alan Stokes wrote:
But minimal.hpp includes the line #include <libs/test/src/execution_monitor.cpp> which fails to compile - because my include path doesn't have a directory with the boost libs directory in it. And nor should it.
This is unfortunate, and arguably a violation of the header policy (libs as a sub-directory name is highly likely to clash with other libraries, unlike boost).
Header files should not be including implementation files. This is especially the case with the minimal test facility, whose whole point is to be usable without requiring linking with implementation files. Changing to textual inclusion of implementation files is not a great improvement.
You are absolutely right. Gennadiy, are you going to fix this? Doug
But minimal.hpp includes the line #include <libs/test/src/execution_monitor.cpp> which fails to compile - because my include path doesn't have a directory with the boost libs directory in it. And nor should it.
This is unfortunate, and arguably a violation of the header policy (libs as a sub-directory name is highly likely to clash with other libraries, unlike boost).
Header files should not be including implementation files. This is especially the case with the minimal test facility, whose whole point is to be usable without requiring linking with implementation files. Changing to textual inclusion of implementation files is not a great improvement.
You are absolutely right. Gennadiy, are you going to fix this?
Doug
What and how exactly are you propose to fix? Gennadiy.
Gennadiy Rozental wrote:
What and how exactly are you propose to fix?
The what is easy - boost/test/* should have no dependency on libs/*. None of the test headers should include anything other than boost/* or C++ standard headers. I suggest you fix it by taking the entire contents of libs/test/src/execution_monitor.cpp and putting them in a new file, say boost/test/execution_monitor_impl.hpp. Then change execution_monitor.cpp to simply say #include "boost/test/execution_monitor_impl.hpp". And finally, change boost/test/minimal.hpp to include execution_monitor_impl.hpp instead of execution_monitor.cpp. - Alan
I suggest you fix it by taking the entire contents of libs/test/src/execution_monitor.cpp and putting them in a new file, say boost/test/execution_monitor_impl.hpp. Then change execution_monitor.cpp to simply say #include "boost/test/execution_monitor_impl.hpp". And finally, change boost/test/minimal.hpp to include execution_monitor_impl.hpp instead of execution_monitor.cpp.
Ok I will do something like this after release. Gennadiy.
On Oct 6, 2004, at 7:42 AM, Gennadiy Rozental wrote:
I suggest you fix it by taking the entire contents of libs/test/src/execution_monitor.cpp and putting them in a new file, say boost/test/execution_monitor_impl.hpp. Then change execution_monitor.cpp to simply say #include "boost/test/execution_monitor_impl.hpp". And finally, change boost/test/minimal.hpp to include execution_monitor_impl.hpp instead of execution_monitor.cpp.
Ok I will do something like this after release.
Gennadiy.
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
participants (1)
-
Alan Stokes -
Alan Stokes
-
Doug Gregor -
Gennadiy Rozental -
John Fuller