Another spirit compile problem using HP aC++
Here's another problem while compiling with aC++. This has been reported to the HP aC++ team, but in the meantime, I'm posting this fix to the list for review and for future users of Spirit for aC++. BTW, I'm a little afraid to commit changes to the repository, so quick question: If I end up committing changes that need to be backed out, can I delete that version that I committed easily? Thanks! boost/spirit/core/primitives/impl/match.ipp:101 ===old=== inline void match<nil_t>::swap(match& other) { std::swap(len, other.len); } ===new=== inline void match<nil_t>::swap(match<nil_t>& other) { std::swap(len, other.len); } -Jerry
DY, JERRY U (SBCSI) wrote:
Here's another problem while compiling with aC++. This has been reported to the HP aC++ team, but in the meantime, I'm posting this fix to the list for review and for future users of Spirit for aC++.
BTW, I'm a little afraid to commit changes to the repository, so quick question: If I end up committing changes that need to be backed out, can I delete that version that I committed easily?
Please don't commit anything before first informing us. For that matter, it would be best to discuss this with other Spirit developers. There is, in fact, a spirit-devel mailing list. Let's continue our discussions there: Spirit-devel mailing list Spirit-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spirit-devel
boost/spirit/core/primitives/impl/match.ipp:101
===old===
inline void match<nil_t>::swap(match& other) { std::swap(len, other.len); }
===new===
inline void match<nil_t>::swap(match<nil_t>& other) { std::swap(len, other.len); }
This is ok. Feel free to commit the changes. Regards, -- Joel de Guzman http://www.boost-consulting.com http://spirit.sf.net
DY, JERRY U (SBCSI) wrote:
Here's another problem while compiling with aC++. This has been reported to the HP aC++ team, but in the meantime, I'm posting this fix to the list for review and for future users of Spirit for aC++.
BTW, I'm a little afraid to commit changes to the repository, so quick question: If I end up committing changes that need to be backed out, can I delete that version that I committed easily?
Yes. You'll see a file boost/spirit/core/primitives/impl/CVS/Entries that lists the current version of match.ipp. Something like /numerics.ipp/1.8/Wed Jan 14 22:00:19 2004// (There doesn't appear to be a match.ipp in that directory...) where the current version in '1.8'. Commit your changes and this will be changed to '1.9'. If all goes horribly wrong and people start shouting at you then back out your local copy: $ cd boost/spirit/core/primitives/impl $ cvs diff -r 1.8 match.ipp > match.diff $ patch -p0 < match.diff And commit the updated file: $ cvs commit match.ipp The version number in CVS/Entries will be incremented to '1.10' but the contents of the file will be identical to those of version '1.8'. $ cvs diff -r 1.8 -r 1.10 match.ipp will list the differences between two versions of the file. Here there should be no differences of course... HTH, Angus kk
participants (6)
-
Angus Leeming -
DY, JERRY U (SBCSI) -
Joel de Guzman